shawnwun / NNDIAL

NNDial is an open source toolkit for building end-to-end trainable task-oriented dialogue models. It is released by Tsung-Hsien (Shawn) Wen from Cambridge Dialogue Systems Group under Apache License 2.0.
Other
348 stars 105 forks source link

deadcode in the DataReader.py file #5

Open yahuvi opened 7 years ago

yahuvi commented 7 years ago

I found two bugs:

1.in line 377,"if v=='dontcare' and s=='this':",where s=='this' ,in CamRest676.json it's not found that the slot equal 'this' issue code location:https://github.com/shawnwun/NNDIAL/blob/740f6d34594bcdd889080ce60c95384bda7594a2/loader/DataReader.py#L377

2.in line 380,"if sda['act']=='request':",where sda['act'] ,variable sda has no attribute 'act' ,because in CamRest676.json,items of DA is string type and similar to the following: "sys": { "sent": "There are several restaurants in the south part of town that serve expensive food. Do you have a cuisine preference?", "DA": [ "food" ] } issue code location:https://github.com/shawnwun/NNDIAL/blob/740f6d34594bcdd889080ce60c95384bda7594a2/loader/DataReader.py#L380