search

shawnwun / NNDIAL

NNDial is an open source toolkit for building end-to-end trainable task-oriented dialogue models. It is released by Tsung-Hsien (Shawn) Wen from Cambridge Dialogue Systems Group under Apache License 2.0.
Other
348 stars 105 forks source link

Possible bug in DataReader.py when loading vocab from dialogues #7

Open garygsw opened 6 years ago

garygsw commented 6 years ago

Hi, I would like to clarify if this is a bug.

https://github.com/shawnwun/NNDIAL/blob/740f6d34594bcdd889080ce60c95384bda7594a2/loader/DataReader.py#L876-L880

Should the extractSeq method in line 878 be called on turn['usr']['transcript'] instead?

The words variable in line 877 is totally ignored, and replaced by the return values of extractSeq in line 878.