search

shawnyapa / todoCodePath

A ToDo Android Application for CodePath
0 stars 0 forks source link

[Android Bootcamp] Project 1 - ToDo App - Review my App #1

Open shawnyapa opened 10 years ago

shawnyapa commented 10 years ago

I've finished the first ToDo app. Please note that I put the Add Task Button into the Action Bar. I really wish I had time to fix some things and clean up the code, but this has to be submitted by midnight today. I did include a ReadME with a GIF walk through. @nesquena @thecodepath

nesquena commented 10 years ago

Shawn,

Glad you were able to submit on time. This was intended in part to give you an introduction to the general rhythm of this course. The course is entirely project based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer to learn all practical Android development and best practices as quickly as possible. We also do a code review for each submitted project.

The next step is to clean up the code base, get persistence working and then continue working on extensions to your todo app. Let's also now schedule a short 5-10 minute phone conversation here. Navigate to August 29th and dates onward from there and choose a 15-minute slot. Let us know if none of those times work.

Once you select a slot, can you make sure to include best number to reach you at? Look forward to chatting soon!

nesquena commented 10 years ago

Shawn, good chatting with you earlier! Will keep an eye out for some extensions to your todo app this weekend before final acceptance. Please update README and raise a new issue when they are ready for review.

shawnyapa commented 10 years ago

Hey Nathan,

Nice chatting with you as well on Friday. I've finished the updates to my ToDo app and raised an issue on Github and updated the ReadMe, etc.

The new features are:

I think the project needs some additional refactoring to appropriately use the new Task class but it does meet all the requirements we discussed on the phone.

If you could review the updates I'd appreciate it.

Also, I think I need some details about exact location for the class tomorrow. Just go to Zynga? And if you have the additional suggested resource list that you mentioned on the phone that would be great.

Thanks again. See you tomorrow, shawn yapa 415 359 6801

On Fri, Sep 5, 2014 at 4:19 PM, Nathan Esquenazi notifications@github.com wrote:

Shawn, good chatting with you earlier! Will keep an eye out for some extensions to your todo app https://gist.github.com/nesquena/843228e83fdc4f5ddc4e#5-extending-your-todo this weekend before final acceptance. Please update README and raise a new issue when they are ready for review.

— Reply to this email directly or view it on GitHub https://github.com/shawnyapa/todoCodePath/issues/1#issuecomment-54693076 .