search

shaxxx / flutter_barcode_listener

Flutter widget to listen for scanned barcode via hardware scanners
MIT License
45 stars 46 forks source link

add first widget test #23

Closed utamori closed 1 year ago

utamori commented 2 years ago

I have created a test to ensure that it works. I also moved it because I think it needs to be the first to determine if it is ENTER or not, is that ok?

shaxxx commented 2 years ago

Your PR modifies original library and creates widget test, that's two different things. While your logic of testing for enter is sound, it makes assumptions about what enter key is on each platform. It's best not to make any assumptions and just process keys AS IS. Let the final user decide what they want.