search

shayaansultan / pe

0 stars 0 forks source link

JSON Override does not work as specified in UG #1

Open shayaansultan opened 2 months ago

shayaansultan commented 2 months ago

The UG says, "EstateEase data are saved automatically as a JSON file [JAR file location]/data/addressbook.json Advanced users are welcome to update data directly by editing that data file."

It does not specify that any edits made while the application is open, will not take effect ever, which is the case.

To test, open the app with the default template, open the addressbook.json, delete a user. This change will be overridden on closing the app.

Medium severity as user may lose changes without knowing

nus-se-script commented 2 months ago

Team's Response

Thank you for bringing this issue to our attention. Addressing this specific problem is currently considered as less important because the application is designed to display updated data whenever the application is opened, provided that any valid changes were made to the JSON file when the application is closed.

It is important to note that the functionality to check for the updated data in JSON does exist; however, the application does not prioritise validation of edits made to the JSON while the application is running concurrently in this current version.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Regardless of if it is considered less important or not, it is still a valid bug, showing a mismatch between UG and application.