search

shayaantx / botdarr

Slack/Discord/Telegram/Matrix bot for accessing radarr, sonarr, and lidarr
GNU General Public License v3.0
151 stars 13 forks source link

!Music Artist Add #### #103

Closed sowie2016 closed 1 year ago

sowie2016 commented 1 year ago

When runnig

!music artist add via the telegram bot I always get the response

Info! - Too many artists found, please narrow search or increase max results to show

I have tried more obscure artists and also added the variable -e MAX_RESULTS_TO_SHOW="500"

The "!music artist find existing" & "!music downloads" work fine so my connection to lidarr is working. Any pointers?

shayaantx commented 1 year ago

@sowie2016 which artist are you trying to add?

Usually when it shows "Too many artists found, please narrow search or increase max results to show" it should be showing the results afterward. Are you saying its showing nothing at all?

sowie2016 commented 1 year ago

Yes that's all it returns.

I tried a few different artists all returning the same error..

!music artist add michael jackson

I added sonarr & radarr just to test and these all returned shows/movies as expected.

shayaantx commented 1 year ago

@sowie2016 I'll look tomorrow morning and get back to you, sounds like a bug

sowie2016 commented 1 year ago

Thank You

shayaantx commented 1 year ago

The underlying telegram api was throwing the following error message

Bad Request: BUTTON_DATA_INVALID

Something has changed in the telegram bot api that is causing the buttons that get appended to each downloadable item to be broken now...

Either its the fact the callbacks are larger than 64 bytes and now they are actually enforcing it (https://core.telegram.org/bots/api#inlinekeyboardbutton) - even tho I don't recall this happening with telegram before. Or there is some content causing the telegram api to reject the callback data.

Still investigating

shayaantx commented 1 year ago

Looks like they are def no longer allowing callbacks for buttons that are larger than 64 bytes, I'll need to come up with some fix for this (I'll look a bit later tonight or tomorrow night and get back to you)

shayaantx commented 1 year ago

So I put up a PR to fix this, https://github.com/shayaantx/botdarr/pull/105, it seems to work, I'll merge it tomorrow (wanna add some tests maybe if I'm not lazy)

@sowie2016

sowie2016 commented 1 year ago

Perfet will wait for the merge and updated docker image

shayaantx commented 1 year ago

merged this, should be available in latest version 5.6.7

gonna close this, lemme know if you have any issues

keep in mind the telegram buttons are basically last for 10 days or so (so if someone was to click "add" after 10 days it wouldn't work anymore, they would have to search for content again this applies to shows, movies too)