shayded-exe / tuneup-prime

NO LONGER MAINTAINED - A library management toolkit for Denon Engine PRIME 🎧
https://community.enginedj.com/t/tuneup-prime-library-management-toolkit-for-windows-macos-create-smart-playlists-relocate-your-tracks-and-more/33067
MIT License
29 stars 2 forks source link

Playlists without folders are moved to the root folder #72

Closed Houseman-HH closed 2 years ago

Houseman-HH commented 2 years ago

Issue description

Since the latest update, I can no longer move my smart lists into subfolders.

With each new analysis they are moved back to the main directory.

This is very annoying and messed up my whole folder structure.

Please fix this bug quickly!

thank you

Steps to reproduce

Screenshots

Environment

shayded-exe commented 2 years ago

Mirroring my reply from the forum

This is an unintended side effect of adding the folders feature. Your folder structure should be replicated in the config file, otherwise playlists without a folder will be moved to the root.

One way I could possibly handle this is if a config doesn’t contain any folders, existing playlists won’t be re-parented and will remain where they are.

Houseman-HH commented 2 years ago

I find that very sad.

Carrying out my engine folder structure with the command lines in the configuration file is cumbersome and time-consuming.

The creation of folder structures is much faster and more comfortable in Engine.

I think this version is more of a step backwards than a step forward.

Maybe they can fix that.

I'm back to 2.20

Best regards

Holger

Am 06.01.2022 um 19:02 schrieb Ryan Shea @.***>:

Mirroring my reply from the forum

This is an unintended side effect of adding the folders feature. Your folder structure should be replicated in the config file, otherwise playlists without a folder will be moved to the root.

One way I could possibly handle this is if a config doesn’t contain any folders, existing playlists won’t be re-parented and will remain where they are.

— Reply to this email directly, view it on GitHub https://github.com/rshea0/tuneup-prime/issues/72#issuecomment-1006799659, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUHOQBX7HTKMX5BUZRJOOSDUUXKK3ANCNFSM5LMX6K3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

shayded-exe commented 2 years ago

I'll get a patch update out later today that allows playlists at the root stay in whatever folder you've placed them in within Engine so your workflow is still possible.

Houseman-HH commented 2 years ago

Great support :)

Am 06.01.2022 um 19:15 schrieb Ryan Shea @.***>:

I'll get a patch update out later today that allows playlists at the root stay in whatever folder you've placed them in within Engine so your workflow is still possible.

— Reply to this email directly, view it on GitHub https://github.com/rshea0/tuneup-prime/issues/72#issuecomment-1006808617, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUHOQBSEQZ3Y3LSUSIBQEMTUUXL3PANCNFSM5LMX6K3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

Houseman-HH commented 2 years ago

Hey I noticed something else:

If, for example, I subsequently change a tag such as comment or rating in a smartlist that has already been created, the title remains in the wrong list with the new changes.

I then have to manually delete the changed titles from the list.

After deleting and re-creating the list, the assignment is correct.

Maybe you can test it - I noticed it by accident

thank you

Am 06.01.2022 um 19:15 schrieb Ryan Shea @.***>:

I'll get a patch update out later today that allows playlists at the root stay in whatever folder you've placed them in within Engine so your workflow is still possible.

— Reply to this email directly, view it on GitHub https://github.com/rshea0/tuneup-prime/issues/72#issuecomment-1006808617, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUHOQBSEQZ3Y3LSUSIBQEMTUUXL3PANCNFSM5LMX6K3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

shayded-exe commented 2 years ago

Are you changing the tag from within Engine, or from the file?

Currently the app only uses Engine's tags to build the smart playlists so if you've edited the file's tag but haven't refreshed those changes within Engine, Tuneup won't see it.

One of the next features I'm adding is the ability to use the file tags (including custom ID3 tags) for smart playlists.

Houseman-HH commented 2 years ago

Only Engine tags will be modified

Am 06.01.2022 um 19:15 schrieb Ryan Shea @.***>:

I'll get a patch update out later today that allows playlists at the root stay in whatever folder you've placed them in within Engine so your workflow is still possible.

— Reply to this email directly, view it on GitHub https://github.com/rshea0/tuneup-prime/issues/72#issuecomment-1006808617, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUHOQBSEQZ3Y3LSUSIBQEMTUUXL3PANCNFSM5LMX6K3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

shayded-exe commented 2 years ago

Interesting, so you're saying you've modified the tag via Engine, but the smart playlists don't take those changes into account?

Could you please open a new bug and post a reproduction example with the song/tags in question and the smart playlist config you're using? It might also be helpful for you to share your Engine database file (it's Engine Library/Database2/m.db).

Houseman-HH commented 2 years ago

Correct- bug is opened

Am 06.01.2022 um 19:52 schrieb Holger Peters @.***>:

Hey I noticed something else:

If, for example, I subsequently change a tag such as comment or rating in a smartlist that has already been created, the title remains in the wrong list with the new changes.

I then have to manually delete the changed titles from the list.

After deleting and re-creating the list, the assignment is correct.

Maybe you can test it - I noticed it by accident

thank you

Am 06.01.2022 um 19:15 schrieb Ryan Shea @. @.>>:

I'll get a patch update out later today that allows playlists at the root stay in whatever folder you've placed them in within Engine so your workflow is still possible.

— Reply to this email directly, view it on GitHub https://github.com/rshea0/tuneup-prime/issues/72#issuecomment-1006808617, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUHOQBSEQZ3Y3LSUSIBQEMTUUXL3PANCNFSM5LMX6K3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

Houseman-HH commented 2 years ago

For explanation: It only affects tracks that were previously in the smartlist!

New tracks that are being added to a lsite for the first time are flawless and the list is correct. But as soon as I change a track in an existing list, the error occurs.

Am 06.01.2022 um 19:52 schrieb Holger Peters @.***>:

Hey I noticed something else:

If, for example, I subsequently change a tag such as comment or rating in a smartlist that has already been created, the title remains in the wrong list with the new changes.

I then have to manually delete the changed titles from the list.

After deleting and re-creating the list, the assignment is correct.

Maybe you can test it - I noticed it by accident

thank you

Am 06.01.2022 um 19:15 schrieb Ryan Shea @. @.>>:

I'll get a patch update out later today that allows playlists at the root stay in whatever folder you've placed them in within Engine so your workflow is still possible.

— Reply to this email directly, view it on GitHub https://github.com/rshea0/tuneup-prime/issues/72#issuecomment-1006808617, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUHOQBSEQZ3Y3LSUSIBQEMTUUXL3PANCNFSM5LMX6K3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.