search

shayhatsor / zookeeper

Apache ZooKeeper .NET async Client
https://nuget.org/packages/ZooKeeperNetEx/
Apache License 2.0
236 stars 53 forks source link

Zookeeper 3.4.12 #27

Open bitchkat opened 6 years ago

bitchkat commented 6 years ago

With Zookeeper 3.4.12 released a on May 1, 2018, is there a timeline for releasing a corresponding version of ZookeeperNetEx? We never saw a 3.4.11 version of ZookeeperNetEx.

I'm happy to help out if needed especially if you can describe your process for porting each release? Do you start from scratch or do you do diffs of the java code and then make corresponding changes to the C# code?

shayhatsor commented 6 years ago

what i did the first time was to convert the code using some commercial converter. then i implemented java stuff in c# to make the java and c# as similar as possible (even added extension methods). then turned everything to be fully async, still making sure to keep the diff to bare minimum. what i usually do when i create a new version of this code: take the apache version i branched from, compare it to the new version, then see what changes have been made to the java client code and port the changes to the c# code. i can't give you a timeline on 3.4.12, but i will start looking at it this weekend. i will ping you if i see i need help. thanks for the update, i haven't been following the apache zookeeper dev lately.

shayhatsor commented 6 years ago

done

bitchkat commented 6 years ago

Since #26 is still open, does that mean it wasn't incorporated into this release? I'd really like to not have to maintain a fork at work and I depend on the fix to the writeLock recipe. I can pull 3.4.12 on monday, reapply my fix, and generate a pull request if needed.

shayhatsor commented 6 years ago

a pull request would be great!

bitchkat commented 6 years ago

WriteLock.cs.txt

Doesn't look like I can generate a pull request since I haven't forked your code publicly. I'm attaching a git diff with the two changes. Both are small one line changes. The first is pulled from the most recent patch in https://issues.apache.org/jira/browse/ZOOKEEPER-645 and the latter is my changed. This code has been running for months in software that makes heavy use of locks.

shayhatsor commented 6 years ago

I haven't yet merged your fix is because although it resolves the problem, I'm not sure it doesn't mask a deeper issue.

bitchkat commented 6 years ago

Take a look at the discussion on https://mail-archives.apache.org/mod_mbox/zookeeper-user/201802.mbox/browser for some discussion on my issue and fix.