Open douggish opened 2 years ago
I noticed that the C# port of LeaderElectionSupport has a mistake when comparing it with the original Java. On this line: https://github.com/shayhatsor/zookeeper/blob/0874166177fbafc47359d7b1cfe7bc0ba99b4a57/src/csharp/src/ZooKeeperNetEx.Recipes/leader/LeaderElectionSupport.cs#L349, the C# port is comparing an event type to a node path.
However, in the original Java here: https://github.com/shayhatsor/zookeeper/blob/0874166177fbafc47359d7b1cfe7bc0ba99b4a57/src/recipes/election/src/java/org/apache/zookeeper/recipes/leader/LeaderElectionSupport.java#L339, it is comparing an event path to a node path.
The C# version doesn't seem correct.
I noticed that the C# port of LeaderElectionSupport has a mistake when comparing it with the original Java. On this line: https://github.com/shayhatsor/zookeeper/blob/0874166177fbafc47359d7b1cfe7bc0ba99b4a57/src/csharp/src/ZooKeeperNetEx.Recipes/leader/LeaderElectionSupport.cs#L349, the C# port is comparing an event type to a node path.
However, in the original Java here: https://github.com/shayhatsor/zookeeper/blob/0874166177fbafc47359d7b1cfe7bc0ba99b4a57/src/recipes/election/src/java/org/apache/zookeeper/recipes/leader/LeaderElectionSupport.java#L339, it is comparing an event path to a node path.
The C# version doesn't seem correct.