search

shayneobrien / coreference-resolution

Efficient and clean PyTorch reimplementation of "End-to-end Neural Coreference Resolution" (Lee et al., EMNLP 2017).
https://arxiv.org/pdf/1707.07045.pdf
185 stars 61 forks source link

A bug, can you fix that? #14

Open freesunshine0316 opened 5 years ago

freesunshine0316 commented 5 years ago

https://github.com/shayneobrien/coreference-resolution/blob/f368f5a06e1d646d60c50d824235576bb8fe4198/src/coref.py#L211

I think there's a bug around the above code. The LSTM encoding does not go along each sentence, as 

pack_sequence

does not work as you thought.

sushantakpani commented 3 years ago

Author's note in span representation section (Lee 2017): Independent LSTM for every sentence should be used as cross sentence context was not useful.