Return ndarrays instead of lists while predicting

shaypal5 / skift

scikit-learn wrappers for Python fastText.

MIT License

234 stars 23 forks source link

Return ndarrays instead of lists while predicting #2

Closed uniaz closed 6 years ago

uniaz commented 6 years ago

The functions predict, predict_proba return lists instead of numpy arrays which makes them unusable with classifiers like sklearn.multiclass.OneVsRestClassifier. GridSearch and other similar functionality also don't work.

This is a quick fix.

shaypal5 commented 6 years ago

Hey! Good catch!

I'm assuming that you meant to write "This is a quick fix" in the pull request that will close this issue? 😄

I'm holding my breath... ❤️

shaypal5 commented 6 years ago

@uniaz ☝️

uniaz commented 6 years ago

I'm on it. Will create a PR soon.

Great repo BTW.

shaypal5 commented 6 years ago

Closed by https://github.com/shaypal5/skift/pull/3