search

shayypy / guilded.py

Asynchronous Guilded API wrapper for Python
https://guildedpy.rtfd.io
Other
135 stars 25 forks source link

Update utils.ISO8601 #16

Closed anytarseir67 closed 3 years ago

anytarseir67 commented 3 years ago

fixes #15

shayypy commented 3 years ago

Has this been tested against timestamps that Guilded will actually send? They end a little bit differently and I can’t remember if this method covers that.

anytarseir67 commented 3 years ago

it already handles timestamps from Guilded, so this only affects timestamps from a datetime.

shayypy commented 3 years ago

Yes, but you removed a second strptime that IIRC I added for edge cases from Guilded (in which no microsecond is included).

anytarseir67 commented 3 years ago

as far as i can tell, the first one handles everything from guilded, i tested this out for a while and i never got any errors.

shayypy commented 3 years ago

Yeah, hence edge case. I should prefer it stays in, and fromisoformat being another layer down.

anytarseir67 commented 3 years ago

readded it.

shayypy commented 3 years ago

Thanks