shazahm1 / WP-Syntax

WP-Syntax WordPress Plugin
connections-pro.com
GNU General Public License v2.0
13 stars 11 forks source link

Fix line number CSS Bug #14

Closed GrumpyRainbow closed 7 years ago

GrumpyRainbow commented 10 years ago

The changes in this pull request aim to fix issue #4 and to fix issue #10.

In this pull request, I chose to set the width on the pre tag inline. Given my setup, I found that the width (in pixels) of the pre element needs to be 8 times the number of digits in the largest number we are trying to display.

I will now show a series of screenshots that capture the changes this pull request will result in.

Screenshots

Current Issue

testing_syntax_highlighting___grumpyrainbow com-3

With Changes [line="1"]

testing_syntax_highlighting___grumpyrainbow com-2

With Changes [line="1000"]

testing_syntax_highlighting___grumpyrainbow com-4

Comments

This is just one way of handling this problem. If you have other ideas, I'm open to hearing them.

Take care!