shazow / callthis

Build a transaction, send a link for someone else to execute it.
https://callthis.link
MIT License
48 stars 4 forks source link

Add Safe Support #21

Closed SonOfMosiah closed 9 months ago

SonOfMosiah commented 1 year ago

Additional requirements here: https://docs.safe.global/safe-core-aa-sdk/safe-apps/get-started#basic-requirements

shazow commented 1 year ago

Great idea, thanks for tracking. Any interest in doing a PR? :)

SonOfMosiah commented 1 year ago

Absolutely. I'll try my hand at adding this in.

shazow commented 1 year ago

Fantastic! Let me know if you have any trouble getting going, I'd like to make callthis more contributor-friendly.

shazow commented 9 months ago

Added a manifest in https://github.com/shazow/callthis/commit/790fb9c1e6acf7740a357c8379f77c228a1206fc, pretty sure it's working now? Didn't need to do anything special for the provider.

SonOfMosiah commented 9 months ago

I think Safe also requires the app to "eager connect" or "auto connect" to the safe wallet.

shazow commented 9 months ago

@SonOfMosiah Does it not work for you rn? I think whatever I did for my custom wallet connecting happened to be compatible with what Safe does. 🙃

SonOfMosiah commented 9 months ago

Is the latest live on callthis.link? Wasn't able to connect through app.safe.global

shazow commented 9 months ago

Ah you're right, it looked like it was working but it was using the wrong wallet.

I think it's actually also a CORS issue at the moment.

shazow commented 9 months ago

Do you have any (working) links handy for how eager/auto connect is supposed to work? Looks like everything is 404 these days. -_-

shazow commented 9 months ago

Ah found it via archive.org https://github.com/safe-global/safe-apps-sdk/tree/main/packages/safe-apps-provider

shazow commented 9 months ago

Alright that was more annoying than I hoped but should do the trick, can you confirm when you get a chance? @SonOfMosiah

shazow commented 9 months ago

https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fcallthis.link&chain=eth