search

shazow / ssh-chat

Chat over SSH.
https://shazow.net/posts/ssh-how-does-it-even/
MIT License
5.59k stars 408 forks source link

Remove howeyc/gopass dependency if possible #380

Closed AbsolutelyLudicrous closed 3 years ago

AbsolutelyLudicrous commented 3 years ago

Hey there

I'm trying to run this project on my OpenIndiana box, but the following error in howeyc/gopass prevents it from building:

../go/pkg/mod/github.com/howeyc/gopass@v0.0.0-20190910152052-7cb4b85ec19c/terminal_solaris.go:32:6: terminalState redeclared in this block
        previous declaration at ../go/pkg/mod/github.com/howeyc/gopass@v0.0.0-20190910152052-7cb4b85ec19c/terminal.go:23:6
../go/pkg/mod/github.com/howeyc/gopass@v0.0.0-20190910152052-7cb4b85ec19c/terminal_solaris.go:39:6: isTerminal redeclared in this block
        previous declaration at ../go/pkg/mod/github.com/howeyc/gopass@v0.0.0-20190910152052-7cb4b85ec19c/terminal.go:27:29
../go/pkg/mod/github.com/howeyc/gopass@v0.0.0-20190910152052-7cb4b85ec19c/terminal_solaris.go:49:6: makeRaw redeclared in this block
        previous declaration at ../go/pkg/mod/github.com/howeyc/gopass@v0.0.0-20190910152052-7cb4b85ec19c/terminal.go:31:43
../go/pkg/mod/github.com/howeyc/gopass@v0.0.0-20190910152052-7cb4b85ec19c/terminal_solaris.go:67:6: restore redeclared in this block
        previous declaration at ../go/pkg/mod/github.com/howeyc/gopass@v0.0.0-20190910152052-7cb4b85ec19c/terminal.go:39:51

I reported the error upstream, but gopass hasn't been maintained since 2017. I believe it would be wise to use a different library. gopass even recommends using crypto/ssh/terminal instead.

shazow commented 3 years ago

Hey thanks, would you be interested in doing a PR that removes the need for gopass?

AbsolutelyLudicrous commented 3 years ago

I don't know any Go, unfortunately, terribly sorry