sshd/terminal: Upstream changes to golang.org/x/term

shazow / ssh-chat

Chat over SSH.

https://shazow.net/posts/ssh-how-does-it-even/

MIT License

5.59k stars 408 forks source link

sshd/terminal: Upstream changes to golang.org/x/term #381

Open shazow opened 3 years ago

shazow commented 3 years ago

We have some important changes in our local fork of golang.org/x/term (formerly x/crypto/terminal), need to upstream them.

Primarily 8c7ea173ad9dc23b8bff237f497904bebc2d9141 via #339

abitrolly commented 1 week ago

@shazow so where to put this commit? Seems to relate to getSize call. However, I am not sure why getSize is not sufficient?

https://cs.opensource.google/go/x/term/+/refs/tags/v0.25.0:term_unix.go;l=59-65

shazow commented 1 week ago

@abitrolly getSize returns the size of the window. We need the width of a character/string. The commit includes a test that needs to pass, so could run it to see if it has been fixed upstream. I haven't checked.