search

shazow / ssh-chat

Chat over SSH.
https://shazow.net/posts/ssh-how-does-it-even/
MIT License
5.59k stars 408 forks source link

Add system bell support to all messages, not just /msg or /reply's #391

Closed tehmichael closed 3 years ago

tehmichael commented 3 years ago

It would be great if users could switch the system bell on or off for the general chat room using a /systembell command of sorts.

Hopefully I'm not overlooking a feature! Thank you - this application is great!

shazow commented 3 years ago

Your terminal can do that. :)

In principle it wouldn't be hard to add but we decided this kind of configuration belongs in the terminal.

shazow commented 3 years ago

Oh also tmux can do it too!

izenynn commented 2 years ago

Just start using ssh-chat a day ago, and was missing this feature, I know you can do that with the terminal but I think this is something the program must support, as a user it can be annoying to make this work, and I will be turning bell on and off only for ssh-chat, so yeah, better if it's integrated.

I was looking at the code and there is a variable to toggle on/off "/msg" and "/reply" bell, so why not add a command to toggle bell on/off, and also another state for all messages? something like:

/bell [off|pm|all]

edit: working on my fork, hope the pr gets approved.