Proposal: Handling `DiamondProxy` in autoload: Respecting `followProxies: false`

[yohamta]

Proposal

Currently, when using autoload with DiamondProxy, facet addresses and ABIs are resolved even when followProxies: false is set. This behavior might not align with the expected use case when users want to retrieve proxies and implementations separately.

Options

• Option 1: For DiamondProxy, do not resolve the implementation ABIs when followProxies: false is set.
• Option 2: Add an isProxyResolved flag to AutoloadResult to indicate whether the proxy has been resolved (e.g., when the ABI for the implementation address has been resolved in cases like DiamondProxy, this flag would be set to true).
• Option 3: When autoload resolves the implementation ABI, return an empty proxies field in AutoloadResult.

I'm not entirely sure which option would be the most suitable at the moment. What do you think?

[shazow]

Ah I think you're right, this is a bug. If followProxies: false, then the DiamondProxy resolving should be bundled into the result.followProxies() callback.

I'll try that fix, but there might have been a reason I didn't do that in the first place, let's find out! :)

[shazow]

This was undone in https://github.com/shazow/whatsabi/commit/fe8fa90b53b7ea789c6a85e59e6a29e145622cdb since we weren't sure what behaviour we want yet.

Also might be a good excuse to refactor autoload into more modular pieces to avoid recursing with repeated getCode.

Punting it to a future release, so we can get the current changes published. :)