shbatm / MMM-Carousel

Displays a single magic mirror module at a time, rotating through the list of configured modules in a carousel-like fashion.
MIT License
42 stars 14 forks source link

[Bug] Positional Mode does not work on this branch #23

Closed mlcampbe closed 1 year ago

mlcampbe commented 5 years ago

Describe the bug This module does not work for me. I install it and it appears to never load. The never has any rotated modules. However, if I remove this and install the barnabycolby/MMM-Carousel that one works just fine with the same configuration. Very odd, any ideas why?

Configuration { module: "MMM-Carousel", config: { transitionInterval: 10000, ignoreModules: ["clock"], mode: "positional", bottom_right: {enabled: true, ignoreModules: [], overrideTransitionInterval: 15000} } }

shbatm commented 5 years ago

I'm not sure. 99% of the changes I've made have been associated with the "slides" mode, but I very well could have broken something in the process. If you are just using the positional rotations, you may be better off sticking with barnabycolby's version until I have an opportunity to test.

Is there a specific feature from my fork you were trying to get working (navigation buttons, etc)?

mlcampbe commented 5 years ago

No not really any specific reason to use your module other than the fact that it had a few more features. I don't plan on using those features now so I am ok with the barnabycolby version at this time.

drdada commented 5 years ago

Hi, Same here, but even the barnabycolby version meets the issue.

Btw, thanks for always being active on this project.

P8ntBal1551 commented 1 year ago

I'm having this issue as well. I'm pretty sure the barnabycolby version has the same issue as well.

here is my config

module: "MMM-Carousel",
position: "bottom_center",
config: {
        transitionInterval: 20000,
        ignoreModules: ["clock", "updatenotification", "alert"],
        mode: "positional",
        bottom_center: {enabled: true}
}
KristjanESPERANTO commented 1 year ago

@mlcampbe I added a position to your config, than it works for me:

  {
    module: "MMM-Carousel",
    position: "bottom_center",
    config: {
      transitionInterval: 10000,
      ignoreModules: ["clock"],
      mode: "positional",
      bottom_right: {enabled: true, ignoreModules: [], overrideTransitionInterval: 15000}
    }
  },

That doesn't match the documentation. I'm not that into the code so I'm not sure if we should update the documentation or this is a buggy behavior.

KristjanESPERANTO commented 1 year ago

@P8ntBal1551 That's another problem. The line bottom_center: {enabled: true} is not complete. This should work:

  {
    module: "MMM-Carousel",
    position: "bottom_center",
    config: {
      transitionInterval: 20000,
      ignoreModules: ["clock", "updatenotification", "alert"],
      mode: "positional",
      bottom_center: {enabled: true, ignoreModules: [], overrideTransitionInterval: 15000}
    }
  },
P8ntBal1551 commented 1 year ago

@KristjanESPERANTO

Thank you. Sorry. Didn't know that "ignoreModules: []" was required

KristjanESPERANTO commented 1 year ago

I'm closing this issue. The missing position can be dealt in issue #37.