search

shbatm / MMM-Carousel

Displays a single magic mirror module at a time, rotating through the list of configured modules in a carousel-like fashion.
MIT License
40 stars 13 forks source link

doesn't work anymore 2.14 #31

Closed sdetweil closed 2 years ago

sdetweil commented 3 years ago

Describe the bug two problems..

  1. now if no position specified for module, its getDom() will never be called. content not shown, so no point

  2. getDom() can return without returning some content.. MUST return SOMETHING, even just empty div

    fix move var div = .. above if clause just before move return div down one line, outside the if closing brace

shbatm commented 2 years ago

Fixed in latest version.

majurgens commented 2 years ago

I'm not sure what you mean by "latest version" but I cloned this repo today and still have this problem. As soon as I added position: "top_bar", it started working. I will raise another issue since this comment may be hidden since I added it to a closed issue