search

shbhuk / barycorrpy

Python version of Barycorr
GNU General Public License v3.0
37 stars 6 forks source link

Devel: formatting, handling of target parameters simplified #20

Closed mzechmeister closed 6 years ago

mzechmeister commented 6 years ago

I found the creation of star_output confusing and I tried to clean it. I think mixing parameters from hip, simbad, and user should not happen inside barycorrpy. An exception might be the rv. which is usually not provided by astrometry. RV is not given by hip and can also miss in simbad. Therefore, the user may want to overwrite this. Now this is handled explicitely.

shbhuk commented 6 years ago

Hi @mzechmeister , I do not understand the changes made to the dictionary inputs for star_par. The code right now allows the user to enter values to overwrite those queried from either Hipparcos or SIMBAD. So the user could query either databases and replace the values found with another RV, Parallax, PM, or coordinates. This way, they could pick and chose the values they want to use.

Could you make two commits, one with the rest of the changes and the next one with the star_output changes, so that we may discuss the latter while I can merge the former (clean ups and minor changes).