search

shbhuk / barycorrpy

Python version of Barycorr
GNU General Public License v3.0
37 stars 6 forks source link

good to clean up this loop #25

Closed indiajoe closed 5 years ago

indiajoe commented 5 years ago

https://github.com/shbhuk/barycorrpy/blob/738ade8de252e33f54985451887550bead3a99cf/barycorrpy/utils.py#L64

1) There is a redundant loop here which can be avoided.

2) Using == operator to compare float is not robust. Better use > comparison.

shbhuk commented 5 years ago

Fixed in v0.2.2.1