search

shbhuk / barycorrpy

Python version of Barycorr
GNU General Public License v3.0
37 stars 6 forks source link

erfa not installed #47

Closed bjfultn closed 3 years ago

bjfultn commented 3 years ago

For versions later than 0.4.1 I'm seeing a ModuleNotFoundError: No module named 'erfa' when trying to import barycorrpy. I don't see this new requirement listed in setup.py. Is this by design or just an oversight?

shbhuk commented 3 years ago

Hi @bjfultn , just checking this right now. We just released a new version of barycorrpy (0.4.2 and 0.4.3) to address the astropy erfa deprecation, which might now require a separate erfa import.

Which python version are you using?

bjfultn commented 3 years ago

3.6.14 Is erfa supposed to be built-in?

shbhuk commented 3 years ago

This is a bug, I'll issue a patch shortly.

bjfultn commented 3 years ago

Would you like me to Dockerize and setup continuous integration so that kind of requirement bug is automatically caught in the future?

shbhuk commented 3 years ago

That would be great, thanks! Meanwhile I've issued a bug fix in v0.4.4, and pushed it to the Master branch. Will push it PyPI shortly.

shbhuk commented 3 years ago

I've pushed v0.4.4 to PyPI. @bjfultn - thank you for working on the CI, and let me know if you need any help for that.