shd101wyy / crossnote

Powerful markdown tool
Other
489 stars 125 forks source link

renderPandoc: Converts code blocks #183

Open gabyx opened 4 years ago

gabyx commented 4 years ago

Why do we need to transform code blocks here? and why is it needed for the later pandoc invocation: https://github.com/shd101wyy/mume/blob/448b28c463597ea46bd4131e2d20d190f9836735/src/markdown-engine.ts#L2678

zean11 commented 3 years ago

The conversion is also the reason why some pandoc filters, which are working on code blocks (like pandoc-imagine) are not displayed correctly. Even though one is using pandoc as a renderer the source is getting changed before it is passed to pandoc for conversion. This means that it breaks compatibility with filters which rely on a specific format of the code block data-info. This is what pandoc-imagine needs:

```{.shebang im_out="stdout"}

!/bin/sh

dot -? ```

I would suggest disabling it when pandoc renderer is active, or adding the option to disable it. Not sure where else it is used and what implications that would have though.