search

shdwmtr / millennium

Apply themes/skins/customize Steam® after the 2023-04-27 Chromium UI update
https://steambrew.app
MIT License
1.09k stars 19 forks source link

[Bug] Plugin wont load #129

Closed FenrirBots closed 4 weeks ago

FenrirBots commented 4 weeks ago

Before Reporting

Describe the Bug

After building and moving the plugin to the plugins folder, millennium gets stuck loading the plugin.

Expected Behavior

Millennium to load without issue.

Steps To Reproduce

Copy examples/plugin pnpm install pnpm run dev copy files to %programfiles(x86)%/steam/plugins/example

Operating System

Windows

Anything else?

millennium-log.txt build-log.txt

FenrirBots commented 4 weeks ago

As an added note this also happens with npm install and npm run dev

shdwmtr commented 4 weeks ago

Yeah hot reload hasn't been fully implemented yet. I put it off since there were no plugins that needed immediate support. I plan to fix this soon.

shdwmtr commented 4 weeks ago

If you restart Steam it will load without issue hopefully

FenrirBots commented 4 weeks ago

This isnt happening while hot reloading, It happens when I start a new instance of steam.

FenrirBots commented 4 weeks ago

I recorded the whole thing but github wont allow mp4 videos to be uploaded so heres an unlisted video https://youtu.be/SUx2m3cEvDk

shdwmtr commented 4 weeks ago

This seems to just be a bug with the sample plugin. I'll look into it!

FenrirBots commented 4 weeks ago

Fixed in pull request found at #130, This also comments out 2 lines that throws errors.

shdwmtr commented 4 weeks ago

Fixed the issue at its root here https://github.com/SteamClientHomebrew/Millennium/commit/8624fab5942c684291edc1c0b8a090731dcd91c0