shdwmtr / millennium

Apply themes/skins/customize Steam® after the 2023-04-27 Chromium UI update
https://steambrew.app
MIT License
1.14k stars 18 forks source link

[Bug] Latest Steam update has seemingly broken the config UI for custom skins that have one #157

Closed NathanL1370 closed 2 weeks ago

NathanL1370 commented 2 weeks ago

Before Reporting

Describe the Bug

Currently, if you attempt to open a custom skin's configuration screen in Steam > Settings > Themes > Config icon, an error message appears on skins like these:

Classic Steam Library: Screenshot 2024-11-06 101249 SpaceTheme for Steam: Screenshot 2024-11-06 101856 Zehn: Screenshot 2024-11-06 101948 Fluenty: Screenshot 2024-11-06 102020 Simple Dark: Screenshot 2024-11-06 102050 Windows 95: Screenshot 2024-11-06 102126

Expected Behavior

The config window should open, instead of an error reference appearing inside the main settings window.

Steps To Reproduce

1) Install a theme that can be configured.

Skins that have a config screen:

2) Open Steam > Settings > Themes and click the gear icon (Pencil icon in Zehn). An error reference should pop up inside the main settings window.

Operating System

Windows

Anything else?

This error prevents a prompt that requires Steam to reload from appearing in the settings window if you try to change the theme or toggle injections, unless you close it and reopen it.

This can also happen on Steam Deck (which is presumably Linux), but I can't say for other Linux distributions. What's interesting for me is that Decky Loader also picks up on this error. Screenshot_20241106_104429

Console output: Screenshot 2024-11-06 105913

shdwmtr commented 2 weeks ago

Thanks for the in depth report! I'll look into it!

NathanL1370 commented 2 weeks ago

Looks like theme configuration UIs are fixed in the current release.

shdwmtr commented 2 weeks ago

Ah, yes; I forgot to close this!