shdwp / xivFaderPlugin

XIV Dalamud plugin to automatically hide UI elements.
15 stars 16 forks source link

xivFaderPlugin tanks performance. #1

Closed Maxunit closed 3 years ago

Maxunit commented 3 years ago

I just installed xivFaderPlugin and somehow, for some reason, it instantly tanks my performance from locked 60 FPS down to 45 FPS or even lower. No idea why and what the reason might be.

EDIT: Somehow...it fixed itself, for now, after restarting the game, but before that it tanked the fps whenever I activated/enabled it.

EDIT 2:

And again...it heavily decreases performance within minutes.

shdwp commented 3 years ago

So what you are saying is that it's fine for a while after you enable it, but then it slows things down after a while? Is it fixed by disabling\enabling the plugin? Or only game restart?

Maxunit commented 3 years ago

Performance is fine without the plugin. Performance decreases a lot after around 5 minutes after I install the plugin and goes back to normal when I disable the plugin.

No idea what the issue might be.

shdwp commented 3 years ago

Can you post dalamud logs? %APPDATA%/XIVLauncher/dalamud.log

Maxunit commented 3 years ago

I checked the dalamud.log myself and after installing the plugin, there is no indication of anything particular happening. Penumbra loading some modded files, the orchestrion plugin telling me about song changes and that's it.

The only thing that happened inbetween was the game going into AFK-Camera Mode after 5 minutes, since I have set the game to do that whenever I go afk for a bit longer. It just happened again and the game went from the 15 FPS in AFK-Cam Mode to only 40 FPS and as soon as I disable the plugin, the FPS jumps back to the intended stable and capped 60 FPS.

EDIT:

After this weird slowdown problem happening, I can toggle the plugin off and on again and it instantly cuts my FPS down again from 60 to 40. This bug only goes away after restarting the game and happens again within those 5 minutes. I will do another test, if it happens again without the AFK timer active and if there is some issue related to FFXIV toggling every UI Element off in AFK Cam or something.

EDIT 2:

Welp...game just crashed with the plugin active, the fps issue present when just logging out, not exiting the game.

shdwp commented 3 years ago

I'll test it with AFK camera.

Regarding the crash - you should probably know yourself that stating that is simply useless without providing any logs.

Maxunit commented 3 years ago

I did not mean to link it directly to your plugin, I am sorry >_<

That might have sounded wrong. I did check the logs and they are empty in regards to your plugin, otherwise I would upload them here.

I did a few more tests (like disabling the AFK Camera and Timer) and the outcomes have been the same. I am trying to get any kind of output from Dalamud that could be used to pinpoint the issue and if it could be a conflict with another plugin (SimpleTweaks? Something else?), but nothing so far.

Iaotle commented 3 years ago

My performance is also tanking when using Fader. Not sure why. Logs: dalamud.log

shdwp commented 3 years ago

Do you, by any chance, have "Hide job bars outside of combat" setting enabled in SimpleTweaks? @Iaotle @Maxunit

Iaotle commented 3 years ago

Yes I do. Disabling it seems to fix the performance issues. Is there a way to add some sort of warning for this in order to make it clear when people have it enabled? Maybe even disable interaction with job gauges if they are hidden by something else?

Maxunit commented 3 years ago

I will check my SimpleTweaks Settings and see, what happens. I feel a bit stupid now ^^"

Iaotle commented 3 years ago

Nope, still getting pretty significant FPS drops, even with the job bars tweak disabled. Around 10fps loss. dalamud.log ..

Maxunit commented 3 years ago

I didn't have the time today to test it, but something I'd check would be to disable any active "UI Tweaks" options, if one has SimpleTweaks installed and any of those active, to see, if that fixes it.

(and then go one by one to see which ones cause problems. Kind of related: FaderPlugin also breaks the Combo Timer feature from SimpleTweaks, at least temporarily. Causes the Combo Timer element to be displayed, even if it should be hidden and therefor it shows up corrupted.)

shdwp commented 3 years ago

It's weird since I also use lots of stuff from SimpleTweaks and I never been able to reproduce the slowdown. Each time I suspect it disabling the plugin changes nothing.

I'll test with combo timer tomorrow to see whether anything changes (since I'm not using that one).

shdwp commented 3 years ago

I think I might have found the culprit, I've screwed up some of the timer work so it has been firing way too much. It that was what did it then fix will be in next version.

shdwp commented 3 years ago

If you want to test here's a folder for devPlugins faderPlugin.zip

Maxunit commented 3 years ago

I loaded it via the "Dev Plugin Locations" feature in XLSettings and it seems to no longer cause slowdowns. Have kept it running for 10 minutes now without a slowdown.

The only issue I noticed right away now, is again related to compatibility with SimpleTweaks. If I have Combo Timer activated, then the affected UI Element ("Paramters") for showing HP and MP/GP is flickering every 2 to 3 seconds, and the Timer is broken. Seems like it clashes somewhere again with Combo Timer from SimpleTweaks. Works fine when disabling "Combo Timer".

Adding to that, the same applies to the "Time until GP Max" Tweak from SimpleTweaks. It causes no conflicts with the "Paramters" UI Element to flicker, but breaks the timer display.

No idea if that can be fixed, made compatible or something or if those UI Tweaks need to be disabled then. Not that they are essential to me, personally.

EDIT: 2 hours later and no slowdowns. Seems like that fixed the fps issues. Thank you a lot, @shdwp !

shdwp commented 3 years ago

Closing this down then. I've also submitted the update to the repo. Ty for the feedback!

Iaotle commented 3 years ago

After a reinstall I think it's a plugin issue. If the timer thing is the culprit, then that's fine. I noticed that changing the display settings in the plugin also alleviates the issue (at least partially). Maybe conflicts between the different setups?

shdwp commented 3 years ago

If you test the intermediate build then you should know for sure. Or wait for the update in the repo.