search

shdwp / xivPartyIcons

XIV Dalamud plugin to show icons instead of names.
25 stars 34 forks source link

Fix Sig Collision #78

Closed MidoriKami closed 1 year ago

MidoriKami commented 1 year ago

As I was checking the sigs of the plugins I have the source code handy, I found this sig has multiple collisions.

Fortunately, the desired function is the first of the collisions, so it resolves properly, this PR includes a new sig that resolves these collisions.

The new sig is current as of 6.31

You could choose to ignore this PR, as the sig does correctly resolve for now, however, in the future that may no longer be the case.

image

squidmade commented 1 year ago

Thank you, I'll test locally and merge this when I get a chance.