search

sheadawson / silverstripe-select2

A silverstripe form field based on http://ivaynberg.github.com/select2/
BSD 3-Clause "New" or "Revised" License
18 stars 18 forks source link

Conficts with silverstripe/tagfield #6

Open lerni opened 9 years ago

lerni commented 9 years ago

Tagfield (https://github.com/silverstripe-labs/silverstripe-tagfield/) used by the new Blogmodule (https://github.com/silverstripe/silverstripe-blog) uses Select2 4.0.0-rc.2. This module uses 3.2 and this seams to cause a conflict.

sheadawson commented 8 years ago

@ohararyan is working on a fix for this at the moment :)

micschk commented 8 years ago

Opening a ticket on Tagfield for this as well (https://github.com/silverstripe-labs/silverstripe-tagfield/issues/77); I think any modules requiring select2 should just pull it in via composer?

require select2/select2 ~4.0

This includes some dependencies and is installed in the vendor dir. It can be required from the added components dir: Requirements::javascript('components/select2/dist/js/select2.js'); Requirements::css('components/select2/dist/css/select2.css');

(or simply include it from CDN;) Requirements::css('//cdnjs.cloudflare.com/ajax/libs/select2/4.0.1/css/select2.min.css'); Requirements::javascript('//cdnjs.cloudflare.com/ajax/libs/select2/4.0.1/js/select2.min.js');

sheadawson commented 8 years ago

Thanks. Composer or CDN solution would be fine. Upgrading this module to use select2 4.0.x will be the grunt of the work

mrgray commented 7 years ago

Hey! Did anyone figure out a way around this?