TinyMCE placeholders not being reverted to shortcode format before save to DB

sheadawson / silverstripe-shortcodable

Provides a GUI for CMS users to insert Shortcodes into the HTMLEditorField + an API for developers to define Shortcodable DataObjects and Views.

MIT License

48 stars 36 forks source link

TinyMCE placeholders not being reverted to shortcode format before save to DB #49

Closed jonom closed 7 years ago

jonom commented 7 years ago

As @tomstgeorge noted in #45, this commit has caused a breaking regression

just made this edit to shortcodable.js and it does fix the 'edit HTML source not saving' issue but breaks the saving of the inserted shortcode dataobject. Now when I publish the page the embeded shortocde dataobject shows on the frontend as an image i.e. they are no longer being converted into shortcodes on save. When I look in the database they are stored as the image and not being saved as e.g [myObject id="2"]

sheadawson commented 7 years ago

Yes this is not cool, I don't have time to look at it at the moment but can merge right away if anyone submits a fix