Click shortcode to resume editing

sheadawson / silverstripe-shortcodable

Provides a GUI for CMS users to insert Shortcodes into the HTMLEditorField + an API for developers to define Shortcodable DataObjects and Views.

MIT License

48 stars 36 forks source link

Click shortcode to resume editing #6

Closed jedateach closed 8 years ago

jedateach commented 9 years ago

It would be super useful to be able to open up a shortcode in the popup box again to continue editing.

Perhaps render something clickable in TinyMCE.

This module is definitely progressing towards a more flexible CMS. Allowing rich content, without requiring users to edit in TinyMCE.

sheadawson commented 9 years ago

Hey Jeremy,

Currently, if you select shortcode text and click the shortcode toolbar icon it will open in editing mode. Is that working for you?

On Fri, Sep 26, 2014 at 3:00 PM, Jeremy Shipman notifications@github.com wrote:

It would be super useful to be able to open up a shortcode in the popup box again to continue editing.

Perhaps render something clickable in TinyMCE.

This module is definitely progressing towards a more flexible CMS.

— Reply to this email directly or view it on GitHub https://github.com/sheadawson/silverstripe-shortcodable/issues/6.

Shea Dawson Web Developer LiveSource

mobile +61 451125303 skype squatchnz email shea@livesource.co.nz web www.livesource.co.nz

jedateach commented 9 years ago

Yep, it works as you describe. Nice. Would be good if you could just put the cursor inside it, or actually click it.

sheadawson commented 9 years ago

Agreed! Feel free to have a go if you're feeling inspired, I won't have time for a wee while :)

jedateach commented 9 years ago

Here is a good reference for doing this:

http://codex.wordpress.org/The_WordPress_Gallery https://github.com/WordPress/WordPress/blob/809baf442b0bd4aaedbbc06de8d6d14408a73d7b/wp-includes/js/tinymce/plugins/wpgallery/plugin.js

Handles the display of the placeholder in TinyMce.

Perhaps we could do the same:

Wrap tags with some kind of markup on TinyMCE load.
Bind events to that markup so Shortcodable editor can open up again.
Remove tags on save. Reduce extra markup back down to short codes.

Markup can be styled nicely, perhaps on a per-shortcode basis. eg:

jonom commented 9 years ago

+1 would love to see this enhancement. Haven't tried this module yet but it looks great thanks @sheadawson

sheadawson commented 8 years ago

The new placeholders will help with this but still need to fix shortcodes that don't have placeholders. I'll close this issue as it's a less specific duplicate of #11