Check if DataObject before calling ORM/::get() on class

sheadawson / silverstripe-shortcodable

Provides a GUI for CMS users to insert Shortcodes into the HTMLEditorField + an API for developers to define Shortcodable DataObjects and Views.

MIT License

48 stars 36 forks source link

Check if DataObject before calling ORM/::get() on class #70

Closed micschk closed 6 years ago

micschk commented 6 years ago

A shortcode may have an id attribute without necessarily representing a database record, so check first.

micschk commented 6 years ago

Hi @sheadawson, this PR is against the 3.0 branch and can be merged without problems (SS~3.5). Could you please tag a minor release including this tweak?

sheadawson commented 6 years ago

@micschk I'm a bit overloaded at the moment, I'll make you contributor so you don't have to wait for me to merge etc

micschk commented 6 years ago

Thanks Shea, accepted. Might take me a little while as well though.