search

sheadawson / silverstripe-shortcodable

Provides a GUI for CMS users to insert Shortcodes into the HTMLEditorField + an API for developers to define Shortcodable DataObjects and Views.
MIT License
48 stars 36 forks source link

Compatibility with Silverstripe 4.2 #75

Open eehondas opened 6 years ago

eehondas commented 6 years ago

Hi, thanks for the module first of all. Any plans to upgrade the module to be compatible with SS 4.2 and above?

sheadawson commented 6 years ago

I don't have any plans myself. I'm not really maintaining this module anymore. If someone else wants to take it on though, that'd be great

eehondas commented 6 years ago

Thank you anyway. To be honest I don't think I have the competence to carry on with it, however I am giving a go at it since I need it. At the moment I am stuck on a js error: openShortcodeDialog: function() { this.openDialog('shortcode'); } It throws this error: Dialog named shortcode is not available. And I've been stuck for some time trying to understand why it was working fine on SS3 and now it doesn't (I can't really find any info about it). I understand what it needs to happen at this specific point, I converted the classes and the backend Form with the shortcode options does load correctly from the Controller. Do you have any idea why this is not working anymore?

sheadawson commented 6 years ago

I think SS4 uses a new version of tinymce which may mean we need to interact with it in a different way. I would suggest you have a look at how SS creates dialog windows for link and image insertion from the new tinymce toolbar.

eehondas commented 6 years ago

Thanks for the tip. I was actually doing that before you suggested it, and this is the bottomline: The SS4 Dialogs are custom coded and are available only for the Files,embed and Link insertion. It looks like openDialog is just a shorthand for the above as it only accepts link,media or embed as a parameter. I actually made the base functionality work by using: tinyMCE.activeEditor.windowManager.open However this way it loses all the SS understyling and it looks bad. I will keep you updated on if I find a better way to do it.

adrexia commented 5 years ago

It looks like it might be Silverstripe 4 compatible now. Any chance of a tagged release? :)

sheadawson commented 5 years ago

@adrexia I've added you as a collaborator feel free to tag and anything else you need :)

adrexia commented 5 years ago

Fantastic, thank you! I don't think its kicked in yet though? I don't yet have the ability to create a tag.

Edit: sorted, thanks. :)

J-Pielage commented 4 years ago

Fantastic, thank you! I don't think its kicked in yet though? I don't yet have the ability to create a tag.

Edit: sorted, thanks. :)

Could it be the case that this does not work anymore at SS ^4.4?