shedaniel / FiberToCloth

The Unlicense
5 stars 4 forks source link

AutoConfig Feature Parity #2

Closed Pyrofab closed 4 years ago

Pyrofab commented 4 years ago

This PR brings FiberToCloth to the latest versions of both Fiber and ClothConfig, and implements many features of the latter that were previously not supported (notably because of lacking Fiber capabilities).

Featuring:

shedaniel commented 4 years ago

Nice progress, I will go work on actual drop-down lists for now so it can be implemented as well

shedaniel commented 4 years ago

I have added setSuggestionMode which is defaulted on (to not change functionality) in the builder of dropdown boxes which disables text input and filtering in Cloth Config 2.14.0

shedaniel commented 4 years ago

is it possible to support enums without manually registering them? The current solution is quite annoying because you need to makeEnum to actually support it

shedaniel commented 4 years ago

Maps can just be a list of subcategory with key and value entry, if that makes sense

Pyrofab commented 4 years ago

is it possible to support enums without manually registering them? The current solution is quite annoying because you need to makeEnum to actually support it

Sure, that's a feature in the next Fiber version.

Pyrofab commented 4 years ago

Applied your suggestions. I don't really feel like messing with nested entries too much right now, so I'll leave the fancy list and map feature out of this PR, if you don't mind.

shedaniel commented 4 years ago

Thanks, will look into this soon.