shedaniel / LightOverlay

To provide users with NEI-like light overlay for Minecraft 1.14+.
Apache License 2.0
86 stars 35 forks source link

[ Feature Request ] Occulsion Boolean for Renderer3D class #164

Closed SolsticeSpectrum closed 1 year ago

SolsticeSpectrum commented 1 year ago

Description: When you want to make sideHorizontal, box, blockLines, sideVertical, line etc. You are left with only lines that are visible through blocks. But what if somebody needs a simple way of making occluded lines? A good source is LightOverlay but it is very complex not even considering if someone would like to render sides like that. If it was built into Renderer3D, it could be simplified a lot and also give addon developers new way of rendering lines or even block sides.

Proof of concept: It could then be used like this for example event.renderer.box(x1, y1, z1,x2, y2 + z2, sideColor, lineColor, ShapeMode.Both, 0, true); event.renderer.sideHorizontal(x1, y, z1, x2, z2, sideColor, lineColor, ShapeMode.Lines, true); where the true value would render the lines occluded by blocks.

I tried to PR this myself but I am bad at coding

SolsticeSpectrum commented 1 year ago

wow I accidentally opened issue request on wrong repo