indicator disappears from certain camera angles/distances with shaders

[Avera9eJoe]

I noticed that running with any shaders makes this mod very difficult to use as the lines disappear at different angles or distances away, and they also seem to have shader lighting applied to it, I.E. they're really dim. Is there a fix for this I'm not seeing, or is this not meant to be used with shaders?

[shedaniel]

Any pictures?

[Web4Guru]

Is this a "definitely won't fix" or would pictures and other info help?

Thanks for creating the mod though, much appreciated.

[shedaniel]

OptiFine related bugs are hard to fix. But I still want to see a picture.

[Avera9eJoe]

The newest updates seem to have fixed the camera angles bug, but there is another issue with certain shaders making the overly very dark: Image of LightOverlay on with no shaders Image of LightOverlay on with sildur's enhanced default Its almost as if something in the pack is being drawn on top of the light overlay. I noticed that shaders also make the outlines caused from structure blocks to get very dim as well. I think this issue is bigger than just LightOverlay though, so it isn't anything you have to worry about.

[shedaniel]

How about the vanilla included chunk borders, are they dim as well? Light Overlay is similar to that.

[Web4Guru]

I tested the chunk borders and it has the exact same problem. I don't use them that often and didn't notice before, but it does the exact same thing. Optifine internal shaders look fine, so maybe it's more on the individual shader developers. I've only tested Sildurs shaders. If you're interested, I could try some others.

I'm using all the latest versions (see below). Here are screenshots. These were all taken from the same position with slight adjustments to the view angle. While walking around, the lines flicker between the black lines, the red lines, and nothing. I say "flicker" but it's angle dependent and often stays as one color for a second or two as you're walking around.

(Edited to add image labels)

No Shaders

Optifine Internal Shaders

Sildurs Enhanced Default Shaders With Missing Overlay

Sildurs Enhanced Default With All Black Lines

Sildurs Enhanced Default With All Red Lines

Sildurs Enhanced Default Shaders - Chunk Border and Light Overlay With Black Lines

Minecraft 1.14.3 Fabric Loader 0.4.8 build 155-1.14.3 Fabric API 0.3.0 build 188 LightOverlay 1.2.1 ModMenu 1.5.4-85 OptiFabric 0.3.2 OptiFine 1.14.3_HD_U_F1 Windows 10

[shedaniel]

Unfortunately I don’t have a good way to fix this as the vanilla chunk borders are affected as well.

[Web4Guru]

Yea, I don't think you should worry about it either. I'd say your mod works perfectly and it's a bug with the shader packs and how MC implements overlays like chunk borders. I'll see what the shader community has to say.

Thanks again!

[Avera9eJoe]

I agree with Web4Guru, I don't think its a big enough issue to worry about. Its good that we're aware of it though.

[shedaniel]

That's true, in any case, sorry for any inconvenience caused!

[JezaGaia]

Just wanted to let you know that there is easy if not "nice" workaround, if you use the numbers overlay instead of the crosses it works perfectly with all the shaders I tried it with (all versions of SEUS, Sildur and Trilton compatible with 1.15) in 1.15.2 with fabric and optifine It's not as nice looking but it's perfctly effective, hope this can help others with this issue.

[zauberparacelsus]

This issue could perhaps be fixed by changing the crosses to be rendered with whatever method is being used to render the numbers? I'm assuming it's some kind of decal texture.

[DranDivine]

I have some news I wanted to share. I ran Minecraft 1.16.1 with Fabric, Optifine, Optifabric, Fabric API and Mod Menu and Light Overlay, and I found out something very interesting and useful. If you have a beacon with a beam, I actually got the lines to work with shaders as long as the beam was in render distance. I tested it and it worked normally for Sildurs Vibrant Shaders and BSL, but SEUS only showed the overlay on top of tall grass for some reason. So if you run Sildurs or BSL and have a beacon, you can use this with the lines mode when close enough to the beacon to see it.

[douira]

Not sure if this is related, but Optifine and Sildurs recently fixed a bug where block outlines and break animations were only visible from certain angles.

[DranDivine]

That might be it. It has been seen for a while, but I didn't think they were looking that much into it.

On Wed, 29 Jul 2020, 01:53 douira, notifications@github.com wrote:

Not sure if this is related, but Optifine and Sildurs recently fixed a bug where block outlines and break animations were only visible from certain angles.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/shedaniel/LightOverlay/issues/5#issuecomment-665352273, or unsubscribe https://github.com/notifications/unsubscribe-auth/APOZZKPT2MJU4RKUR2JFD4DR55QIXANCNFSM4HYEYIFA .

[douira]

Tested it, the lines are still buggy with shaders on. They're only visible in a 90° viewing direction range.

[DranDivine]

Oh dang it. Oh well. Better keep hoping then for a fix. :p

On Wed, 29 Jul 2020, 11:26 douira, notifications@github.com wrote:

Tested it, the lines are still buggy with shaders on. They're only visible in a 90° viewing direction range.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/shedaniel/LightOverlay/issues/5#issuecomment-665550108, or unsubscribe https://github.com/notifications/unsubscribe-auth/APOZZKLGFPOA2NI3KKHC67TR57TMZANCNFSM4HYEYIFA .

[Avera9eJoe]

The current fix for now is to use the number view instead of lines; for some reason numbers work perfectly fine still

From: DranDivine notifications@github.com Sent: Wednesday, July 29, 2020 2:29 AM To: shedaniel/LightOverlay LightOverlay@noreply.github.com Cc: Joe Joe@hafhead.com; Author author@noreply.github.com Subject: Re: [shedaniel/LightOverlay] indicator disappears from certain camera angles/distances with shaders (#5)

Oh dang it. Oh well. Better keep hoping then for a fix. :p

On Wed, 29 Jul 2020, 11:26 douira, <notifications@github.com mailto:notifications@github.com > wrote:

Tested it, the lines are still buggy with shaders on. They're only visible in a 90° viewing direction range.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/shedaniel/LightOverlay/issues/5#issuecomment-665550108, or unsubscribe https://github.com/notifications/unsubscribe-auth/APOZZKLGFPOA2NI3KKHC67TR57TMZANCNFSM4HYEYIFA .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shedaniel/LightOverlay/issues/5#issuecomment-665551320 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIO7CL6FTIA5IMPKDEG5X3R57TUTANCNFSM4HYEYIFA . https://github.com/notifications/beacon/ABIO7COJUGKG3UZXU7OKNFLR57TUTA5CNFSM4HYEYIFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE6VYDWA.gif

[DranDivine]

Well, perfectly is not quite right either. It works most of the time, but sometimes it messes up and I see like a item template rather than a number, as well as I can also see them through walls, which is more annoying. But yeah, they still work. Either way, I went back to playing without shaders so I can see the crosses. Lol.

On Thu, 30 Jul 2020, 00:50 Joe, notifications@github.com wrote:

The current fix for now is to use the number view instead of lines; for some reason numbers work perfectly fine still

From: DranDivine notifications@github.com Sent: Wednesday, July 29, 2020 2:29 AM To: shedaniel/LightOverlay LightOverlay@noreply.github.com Cc: Joe Joe@hafhead.com; Author author@noreply.github.com Subject: Re: [shedaniel/LightOverlay] indicator disappears from certain camera angles/distances with shaders (#5)

Oh dang it. Oh well. Better keep hoping then for a fix. :p

On Wed, 29 Jul 2020, 11:26 douira, <notifications@github.com <mailto: notifications@github.com> > wrote:

Tested it, the lines are still buggy with shaders on. They're only visible in a 90° viewing direction range.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/shedaniel/LightOverlay/issues/5#issuecomment-665550108 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/APOZZKLGFPOA2NI3KKHC67TR57TMZANCNFSM4HYEYIFA

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/shedaniel/LightOverlay/issues/5#issuecomment-665551320> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABIO7CL6FTIA5IMPKDEG5X3R57TUTANCNFSM4HYEYIFA> . < https://github.com/notifications/beacon/ABIO7COJUGKG3UZXU7OKNFLR57TUTA5CNFSM4HYEYIFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE6VYDWA.gif>

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/shedaniel/LightOverlay/issues/5#issuecomment-665970104, or unsubscribe https://github.com/notifications/unsubscribe-auth/APOZZKKVRKFJQEFUBR34AGDR6CRTNANCNFSM4HYEYIFA .

[Microlife-JasonLi]

OptiFine_1.16.4_HD_U_G5 light-overlay-5.6.1 Number mode

[ljoonal]

Also seems to be an issue with Iris, where both the numbers and crosses aren't visible at all. Wanted to note it here since as opposed to Optifine the source code of Iris seems to be available should someone want to investigate the issue further.

[coderbot16]

This is fixed on the side of Iris in https://github.com/IrisShaders/Iris/tree/1.16.x/refactor/bulletproof-state-tracking and this fix will be included in a future Iris release.

Of course, OptiFine compatibility will still be broken, but clearly that is an OptiFine issue, not an issue with Light Overlay.