search

shedaniel / REIPluginCompatibilities-Issues

0 stars 0 forks source link

[Bug] 1.18.2 Forge - Compass not being pulled in crafting #11

Closed Raidobw2 closed 1 year ago

Raidobw2 commented 2 years ago

What happened?

Hello, when crafting recipes using the "+" in REI, all recipes do not pull the compass into the grid for you automatically. The clock also has the same behavior as well.

Versions: Minecraft 1.18.2 Forge 40.1.52 REI RoughlyEnoughItems-8.3.501.jar REI Hacks RoughlyEnoughItems-jei-internals-workaround-8.3.501.jar Modpack FTB Plexiglass Mountain 1.1.1

Steps to reproduce:

  1. Grab the ingredients to make a map (8 paper and 1 compass)
  2. Open the gui of a crafting table
  3. Press 'u' on a compass for recipes using it
  4. Find the map recipe and click the "+" next to it

image

https://user-images.githubusercontent.com/17010632/176589858-bdf01014-f293-4357-a0e2-61ffeb8159c3.mp4

What mod loaders are you seeing the problem on?

Forge

What do you think this bug is of?

Relevant log output

There is nothing in the logs anywhere about this sorry

Anything else?

Thank you in advance for investigating!

Raidobw2 commented 2 years ago

I've done a binary search removing mods from Plexiglass Mountain (in-dev with updated REI) and ended up with this as the modlist: architectury-4.5.75-forge.jar, cloth-config-6.2.62-forge.jar, RoughlyEnoughItems-8.3.510.jar. On Forge 40.1.60.

If I try and craft an empty map with the + symbol, the 8 paper gets put in the table but the compasses stay in my hotbar

MaxNeedsSnacks commented 2 years ago

Pretty sure I've figured out the issue here; Quark assigns NBT data to compasses (and clocks), which is why if you check your inventory you likely have a Compass with NBT: 2 Tag(s) in the tooltip.

I'm assuming this breaks REI's crafting table transfer handler as it changes the item's hash, so REI doesn't pull it into the table...

(Also, since the NBT data obviously remains even after uninstalling Quark, you'd have to cheat in new compasses to even notice the difference, so I can see how you ended up with just the minimal required mod set and still had the issue)

Raidobw2 commented 2 years ago

That makes sense! Thanks for finding that out Max, wow

MaxNeedsSnacks commented 2 years ago

Turns out this issue exists with the vanilla recipe book as well, see https://github.com/VazkiiMods/Quark/issues/3775

shedaniel commented 1 year ago

Closing this as this is caused by Quark.