[Bug] hidden entries are shown in recipe lookup tag cycle

rlnt commented 2 years ago

What happened?

It's pretty much this issue that was fixed in the past but it happens again now: https://github.com/shedaniel/RoughlyEnoughItems/issues/783

When hiding items in REI, they will still appear in recipes using their tag. Here is a preview.

All Tin Ingots are hidden except one but you can still see all the other Tin Nuggets in recipes which is pretty annoying as some mods rely on that information like Refined Storage for recipe encoding.

What mod loaders are you seeing the problem on?

Forge

What do you think this bug is of?

[X] Visual
[X] Recipe Lookup
[ ] Cheat Mode
[ ] Plugin Integration / JEI Plugin Compatibility
[ ] Others

Relevant log output

Anything else?

No response

By submitting this issue, I have included the necessary logs by pasting the contents into the correct location or attaching the file as an upload.

[X] Yes, and I did not use any paste services other than GitHub Gists.

By submitting this issue, I have confirmed my REI and REI's dependencies are up to date.

[X] Yes

rlnt commented 1 year ago

This was introduced through the filtering API. The compat layer now automatically uses filtering when something is hidden through JEI instead of only removing entries from the entry list.

Dr-WeiAL commented 1 year ago

I don't think it solves the problem, because I can still reproduce it in the latest version of REI

rlnt commented 1 year ago

If you are using Almost Unified, I am not surprised. The fix for this was introduced in the newest version of AU which also depends on JEI 10 and because of the REI compat layer issue, you can't use the newest version.

Dr-WeiAL commented 1 year ago

Well, then it looks like I'll have to use JEI for the time being

shedaniel / REIPluginCompatibilities-Issues