search

shedaniel / REIPluginCompatibilities-Issues

0 stars 0 forks source link

[Bug] Almost Unified requires jei 10, but REI Plugin Compatibility is jei 9 #21

Closed Dr-WeiAL closed 1 year ago

Dr-WeiAL commented 1 year ago

What happened?

image

And the other side can't downgrade to jei 9 image

Will this problem be solved? Or can it only be downgraded

What mod loaders are you seeing the problem on?

Forge

What do you think this bug is of?

Relevant log output

[latest.log](https://github.com/shedaniel/RoughlyEnoughItems/files/9946477/latest.log)

Anything else?

No response

By submitting this issue, I have included the necessary logs by pasting the contents into the correct location or attaching the file as an upload.

By submitting this issue, I have confirmed my REI and REI's dependencies are up to date.

rlnt commented 1 year ago

I want to add to this because I look like a dick in this screenshot. Max is on our team and it's more like a joke.

About the issue: I've seen the report about the AE2 mod here on GitHub as well when it required JEI 10 as minimum.

It was closed because it was fixed on their side which is pretty odd because it doesn't target the main issue. I understand that maintaining the compat layer is a lot of work and a major version change of JEI within a MC version sucks but we can't support JEI 9 and 10. You could do that if you wouldn't rely on internals, but sadly we do.

Do you plan to update the compat layer to support JEI 10 in the future? Since it's beta now, I think a lot of more mods will update to it which breaks all support with REI as it mimics to be JEI 9.

shedaniel commented 1 year ago

It is not possible to support both JEI 9 and JEI 10 at the same time due to JEI 10 removing all references to FluidStack in the common api. @DAmNRelentless

rlnt commented 1 year ago

Yeah, Max told me about this. My initial thought was that, since the REI compat layer mimics JEI, an update to JEI 10 would drop JEI 9 support completely, now since it's not alpha anymore.

I'd understand if that's not gonna happen, it's just a really messed up situation right now. It's pretty much the same thing that will happen in the future with Vanilla. Major breaking changes in a minor version.

shedaniel commented 1 year ago

Yeah I don't believe dropping support for the majority of JEI plugins is a good idea just to make one or two JEI 10 plugins work. That would mean the new compat layer is non functional until most mods update to JEI 10.

The most unfortunate thing is that this is happening to 1.18.2, which some mods have already moved on to 1.19 and an update to their JEI compat would be unlikely.

Dr-WeiAL commented 1 year ago

Strangely enough, all the original JEI9 plugins worked fine when I was using JEI10

rlnt commented 1 year ago

Mods that implemented their JEI plugin on JEI 9.7 work with JEI 10 as well.

Dr-WeiAL commented 1 year ago

Mods that implemented their JEI plugin on JEI 9.7 work with JEI 10 as well.

So theoretically upgrading to jei10 should not affect much, right? I don't know much about these

shedaniel commented 1 year ago

No, entire APIs were taken away, even though they were already deprecated in JEI 9.7, they are still supported.

shedaniel commented 1 year ago

Relentless got back to me and said Almost Unified should now support JEI 9. image