search

shedaniel / RoughlyEnoughResources

Creative Commons Zero v1.0 Universal
4 stars 5 forks source link

Update to 1.20.1 #10

Closed ThexXTURBOXx closed 11 months ago

ThexXTURBOXx commented 1 year ago

Tested this in dev and production and everything seems to work fine

This also includes #7 even though it should not be required anymore

Closes #7 Fixes #6 Fixes https://github.com/theorbtwo/RoughlyEnoughResources/issues/83

sternschnaube commented 1 year ago

Thanks for the update 🥳

ThexXTURBOXx commented 11 months ago

As far as I can tell, most of the changes are actually real changes and the style changes only apply to two files. I will see in a few hours if I have enough time to fix those. Otherwise I don't see what should be wrong

shedaniel commented 11 months ago

I appreciate this pull request, but merging this makes it hard to cherry pick stuff over and maintain stuff in the future. You changed indents in many files, messed up imports, added random line breaks.

After removing unrelated changes, the diff changed from +314 −237 to +59 −58, there is no way that wasn't significant.