search

shedaniel / SmoothScrollingEverywhere

Adds smooth scrolling to every list in Minecraft.
Apache License 2.0
20 stars 20 forks source link

1.17.1 Port #23

Closed Deathstar8 closed 2 years ago

Deathstar8 commented 2 years ago

1.17.1 port. The code is from the 3.0.3 version rather than the 3.0.2 version, so there are a lot of changes. Works perfect when testing with and without other mods (Specifically, other mods from shedaniel such as REI and Slight GUI Modifications, as well as their dependencies.) Notable changes to code were additions of 3.0.3's code, as well as updating the config save/load within it.

Edit: It seems as though that the game crashes while using the normal launcher, though not while using third party launchers like MultiMC. I don't know why this happens. Will try to find a solution.

Edit2: After looking at it, it seems as though the same problem happens. I've reverted it back to the original code I had. I just can't get the github repo version of my mod to build the mod with cloth-config nested in it. Will try to figure it out.

Edit3: Problems fixed. Ready to review! (Turns out I'm just dumb and was on a wild goose chase when all I needed to do was fix the smoothscrollingeverywhere.mixins.json file. Silly me.)

Jfamig commented 2 years ago

Is this port available yet?

Deathstar8 commented 2 years ago

If you mean ready to use, then yeah. You can just build the repo. Been using for a bit and it works fine, including with other mods. Still waiting on any response from shedaniel though. Would like to see the PR merged and an update to the Curseforge page soon.

shedaniel commented 2 years ago

Thanks, I will draft an update soon