shedd / duckpan-vagrant

Vagrant + Chef virtual development environment for DuckDuckGo (http://duckduckhack.com)
Apache License 2.0
5 stars 5 forks source link

Include latest security & bugfix patches by switching to the cloud-images.ubuntu.com boxes #18

Closed mikedep333 closed 10 years ago

mikedep333 commented 10 years ago

As a clickbait ad might say "This neat trick lets you patch your boxes."

Before you merge this though, can you identify any regression tests that I should run? So far I have just been running "duckpan" and making sure that the manpage comes up.

shedd commented 10 years ago

This sounds awesome!

I don't have a formal regression test - when testing the previous changes, I destroyed my existing duckpan-vagrant box and rebuilt it from scratch, ensuring that it came up and that I could run duckpan query successfully.

The DDG team might be able to suggest a more complete smoke test? cc @yegg @moollaza

The changes you've been submitting have been really helpful - I've granted you committer access to the repo so that you can merge this and any other improvements that you think would be useful!

moollaza commented 10 years ago

@shedd @mikedep333 making sure duckpan server and duckpan query run is a pretty good test. Those would required that either the zeroclickinfor-spice and/or zeroclickinfo-goodies repos are cloned and their dependencies installed -- duckpan installdeps from the root of the repo.

Right now duckpan doesn't really have a way of testing itself, but there are tests in the duckpan repo that could be run -- though I'm not sure that'll help?

I suppose the easiest way to confirm is to send a message to the duckduckhack developer list asking anyone who uses duckpan-vagrant to give the new version a try?

How's that sound?

mikedep333 commented 10 years ago

Hey guys,

I decided to run duckpan check and to test the zeroclickinfo-goodies repo as a regression test.

duckpan check succeeds. But with the repo, running duckpan query and duckpan server gives me this output:

vagrant@vagrant-ubuntu-precise-64:~/zeroclickinfo-goodies$ duckpan query Checking for latest App::DuckPAN ... 0.141 Checking for latest DDG Perl package... 0.122

Using the following DDG instant answers:

Use of uninitialized value $_ in concatenation (.) or string at /home/vagrant/perl5/lib/perl5/App/DuckPAN/DDG.pm line 57.
mikedep333 commented 10 years ago

Hey guys, it looks like that issue in DDG.pm was just a bug in DuckPAN 0.141. Updating to 0.142 fixed it. duckpan query and duckpan server now work. I am merging now. Thanks.

shedd commented 10 years ago

Great, thanks for confirming that and merging!

moollaza commented 10 years ago

@mikedep333 glad that our fix worked - we noticed a bug when our Travis build very recently started failing. I'm curious about your setup though, because I was unable to recreate that error on my dev machine.

mikedep333 commented 10 years ago

@moollaza were you using DuckPAN 0.141?

moollaza commented 10 years ago

@mikedep333 yup I was on 0.141

mikedep333 commented 10 years ago

If you'd like me to investigate it further, I will.

My setup was the duckpan-vagrant code here. It was on this commit.