search

sheebz / phantom-proxy

a lightweight proxy that lets you to drive phantomjs from node.
MIT License
137 stars 34 forks source link

Implementing page.settings.set and page.settings.get #27

Closed AndrewRayCode closed 11 years ago

AndrewRayCode commented 11 years ago

Currently you can set the page properties but not the page settings. This patch allows you to do so. Note this does NOT allow for setting multiple page settings at once. It would be more work, and this is in line with how page.set works anyway

Please note that I am mad at you now for how much work this took to figure out.

sheebz commented 11 years ago

I merged this, but after thinking about it, I'm not 100% its needed. I'd like to verify that this can't already be done. Can you try using page.set('settings', {...})? Would like to verify this before I publish.