No need for custom request dependency

sheebz / phantom-proxy

a lightweight proxy that lets you to drive phantomjs from node.

MIT License

137 stars 34 forks source link

No need for custom request dependency #39

Open kevzettler opened 11 years ago

kevzettler commented 11 years ago

Regarding the modifications to lib/request.js mentioned: https://github.com/sheebz/phantom-proxy/issues/30#issuecomment-12200992

http-headers are supposed to be case insensitive I know @mikeal of request has been adamanat about this. http://stackoverflow.com/questions/5258977/are-http-headers-case-sensitive

Sounds like a bug with the phantomjs server.

sheebz commented 11 years ago

Basically would need a simplified version of request, maybe just use native node api. Probably wouldn't be too bad given that we have pretty consistent request patterns and don't need a lot of other stuff in there. Not to high on my priority list, but if someone wrote a patch I'm all for it.