search

sheehan / grails-console

A web-based Groovy console for interactive runtime application management and debugging
Apache License 2.0
77 stars 42 forks source link

Question: Is Grails Console stealing logs? #77

Open kdybicz opened 1 year ago

kdybicz commented 1 year ago

If console is running on a working server, then wouldn't this code steal some of the System output (ie. logs from working jobs) from the output stream and never put them back?

sheehan commented 1 year ago

Yeah System.out is redirected to the web console while console code is executing. I was going to switch that to use TeeOutputStream or something like that, but never got to it.

kdybicz commented 1 year ago

I was thinking about doing it myself. I even forked this repo, but the code is too far gone for my skills... with the fs package gone I tried to update all dependencies and gulp script to do the job, but there seems to be a bit strange circular dependency sort off in this repo needed to build new package... and I gave up. Any chance you will be running any sort of maintenance of this repo anytime soon?

kdybicz commented 1 year ago

@sheehan if I would provide you a PR with updated node dependencies, gulp files converted to "latest standards" and some cleanup in grails3/plugin code, would you be keen to release new version of plugin?

FYI: my changes simply remove hijacking System.out, but I would be ok if you would like to make it configurable instead.

FYI 2: I tried my luck with TeeOutputSteam, but regardless the approach I was unable to get consistent results in case of concurrent code execution in 2+ console windows.

kdybicz commented 1 year ago

PR in question #78 😉