search

sheehan / grails-console

A web-based Groovy console for interactive runtime application management and debugging
Apache License 2.0
78 stars 41 forks source link

Upgrade plugin to Grails 6.x #81

Open vsachinv opened 3 months ago

vsachinv commented 3 months ago

@sheehan I have upgraded the plugin to Grails 6.x and also included changes requested by @kdybicz. I will publish the same to public maven repo as well.

vsachinv commented 3 months ago

@sbglasius Could you please check PR and let me know if I need to raise PR on https://github.com/gpc/grails-console ?

vsachinv commented 3 months ago

@sbglasius Yes tested and working fine. Waiting for @sheehan approval.

sheehan commented 3 months ago

Hi @vsachinv, thank you for doing this update! One question, is it necessary to copy the plugin for each version? Originally I had separated grails2 and grails3 because they had significant changes including how the plugins were published. I haven't worked with grails for a bit and am not familiar with whats changed in the last few versions, but I assume we'd just want to publish one new version in Maven Central that would be compatible for grails 3-6? Is that correct?

vsachinv commented 3 months ago

@sheehan No not required but UI generate scripts were written for Grails specific versions so rather altogether removing and revamping whole code base I followed the same pattern having folder for each version. I would clean up if required.

sheehan commented 2 months ago

I'm archiving this repo as suggested by @sbglasius so I guess you should move this PR to the gpc repo.