search

sheehan / grails-handlebars-resources

This plug-in supports using Handlebars.js templates with the Grails Resources Plugin.
Other
9 stars 8 forks source link

Templates not compiled when production doesn't use expanded WAR #16

Open seb-grant opened 10 years ago

seb-grant commented 10 years ago

Love the plugin, thanks for the work on it.

I've run into an issue whereby deployments that don't use the expanded WAR don't compile the .hbs files and simply spit them out in the page as JS files with uncompiled content (breaking the JS).

I have tracked this down to this log line:

ServletContext resource [/console/templates/message.hbs] cannot be resolved to absolute file path - web application archive not expanded?

Which then led me to:

https://github.com/paulfairless/grails-lesscss-resources/pull/8

This fix basically uses a URL for the input resource, rather than a file on the filesystem; one suggestion is that Tomcat may not return a URL for unknown MIME types.

Anyway, I have applied the above patch (albeit quite crudely) to my local copy of the plugin and this has confirmed to work in production with an unexpanded WAR file.

Is this something that could go into the plugin?

Thanks!

Sebastian

sheehan commented 10 years ago

Thanks Sebastian. I'll take a look as soon as I get a chance to test it.