sheehan / job-dsl-playground

An app for debugging Groovy scripts using the Jenkins Job DSL
http://job-dsl.herokuapp.com/
Apache License 2.0
88 stars 33 forks source link

scm#git#cleanBeforeCheckout is wrong. #29

Closed wuhuizuo closed 8 years ago

wuhuizuo commented 8 years ago

The Job dsl:

job('b') {
  scm {
            git('xxx.git', 'master') {
                extensions {
                    cleanBeforeCheckout()
                }
            }
        }
}

The xml result

<!-- 1. b -->
<project>
    <actions></actions>
    <description></description>
    <keepDependencies>false</keepDependencies>
    <properties></properties>
    <canRoam>true</canRoam>
    <disabled>false</disabled>
    <blockBuildWhenDownstreamBuilding>false</blockBuildWhenDownstreamBuilding>
    <blockBuildWhenUpstreamBuilding>false</blockBuildWhenUpstreamBuilding>
    <triggers class='vector'></triggers>
    <concurrentBuild>false</concurrentBuild>
    <builders></builders>
    <publishers></publishers>
    <buildWrappers></buildWrappers>
    <scm class='hudson.plugins.git.GitSCM'>
        <userRemoteConfigs>
            <hudson.plugins.git.UserRemoteConfig>
                <url>xxx.git</url>
            </hudson.plugins.git.UserRemoteConfig>
        </userRemoteConfigs>
        <branches>
            <hudson.plugins.git.BranchSpec>
                <name>master</name>
            </hudson.plugins.git.BranchSpec>
        </branches>
        <configVersion>2</configVersion>
        <disableSubmodules>false</disableSubmodules>
        <recursiveSubmodules>false</recursiveSubmodules>
        <doGenerateSubmoduleConfigurations>false</doGenerateSubmoduleConfigurations>
        <authorOrCommitter>false</authorOrCommitter>
        <clean>false</clean>
        <wipeOutWorkspace>false</wipeOutWorkspace>
        <pruneBranches>false</pruneBranches>
        <remotePoll>false</remotePoll>
        <ignoreNotifyCommit>false</ignoreNotifyCommit>
        <gitTool>Default</gitTool>
        <skipTag>true</skipTag>

    </scm>
</project>

wrong line:

        <extensions>
            <hudson.plugins.git.extensions.impl.PerBuildTag></hudson.plugins.git.extensions.impl.PerBuildTag>
        </extensions>
sheehan commented 8 years ago

Thanks @wuhuizuo, but if you see a bug in the DSL you should file a ticket here: https://issues.jenkins-ci.org/browse/JENKINS/component/16720/

wuhuizuo commented 8 years ago

@sheehan ok, done: JENKINS-34551