Issue in 1.8.3-1.8.4

[GoogleCodeExporter]

So Far I've found this bug in 1.8.3 and 1.8.4:

I have two shops, a gem shop and a everything else shop because of the 5k 
limit, when I load trading it auto selects the default 
"ForumExportTemplate.txt" and gives me an error saying:

"Shop text is 56406 characters, which exceeds the 50,000 character limit on the 
pathofexile.com forum!"

I know the issue, that's why I have a gear.txt and gems.txt for each shop (a 
gear/everything else shop and a gem shop)

If you could make it remember the last .txt on load it would be less annoying, 
and also recode the system so ForumExportTemplate.txt is in settings.xml where 
you put your extra .txt's and you can safely remove it so it doesn't load. 

Thanks so much for rolling out the updates! I'm going to test the new "no 
duplicate items" update asap!

Original issue reported on code.google.com by marat...@gmail.com on 13 Sep 2014 at 9:08

[GoogleCodeExporter]

I've just updated my shop via 1.8.4 that says removes duplicate item code 
generation and a quality gem that's in the quality spoiler also appears in the 
support spoiler. I've attached both the .txt files I use for generating my 
shops.

Gear.txt is used for:
https://www.pathofexile.com/forum/view-thread/1026241

Gems.txt is used for:
https://www.pathofexile.com/forum/view-thread/1030767

If you go to the gem shop you'll see what I mean.

Also I really hope you consider my "attack" veriable.

for example RedAttacks would bring up:
Cleave
Sweep
Lightning strike
Etc

BlueAttacks:
Freezing Pulse
Fireball
Ice Spear
etc

Green Attacks:
Lightning Arrow
Rain of Arrows
Spectral throw
etc

You can't make this work via a ton of current Variables so you'd actually have 
to go to the wiki and find "attacks". No auras, supports, etc.

Thank you and would you like me to keep updating you with what I 
discover/suggest here or on github.

Original comment by marat...@gmail.com on 13 Sep 2014 at 9:31

Attachments:

• Gear.txt
• Gems.txt

[GoogleCodeExporter]

First off, lets address the duplicate issue. The duplicates you're seeing is 
not the duplicate bug that was fixed in 1.8.4, what was happening is that the 
same items were showing up in the same category/spoiler. Eg: under quality gems 
you would see the same 20% quality FP gem twice.

The duplication you're seeing is due to the way Procurement works, it displays 
the same items multiple times if it belongs to each category. There is no way 
for Procurement to know if you want a quality support gem to be in the quality 
spoiler or the support spoiler. The template is customizable, so the idea is 
for the user to come up with a layout specific to their shop and what they're 
selling so as to minimize the duplication.

As for your attack variable, there is already something close to what you've 
described. If you take a look at the wiki page for "Forum Template and 
Generation", you'll see some of the gem categories that are available:

"gems can now be filtered by the categories they are listed under. Available 
categories currently are: AoE, Attack, Aura, Bow, Cast, Chaining, Chaos, Cold, 
Curse, Duration, Fire, Lightning, Melee, Mine, Minion, Movement, Projectile, 
Spell, Totem, Trap and Support. Simple examples are:"

    SupportGems - All support gems
    AuraGems - Aura gems such as Haste or Vitality
    CurseGems - Curse gems such as Temporal Chains or Conductivity 

Categories can also be combined, but only twice. Examples are:

    ColdSpellGems - All cold spell gems
    FireProjectileGems - All cold projectile gems 

If you take a look on the PoE wiki you can see all the gems and their 
categories, all of which are supported in Procurement.

Original comment by stickymaddness on 13 Sep 2014 at 10:20

• Changed state: Accepted
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

thanks for the reply, I've tried combos via the poewiki (not a scrub)
ColdSpell does not bring up all cold attacks, brings up auras; also can bring 
up a green gem (Hatred that's a green gem, aura, and not an attack)

FireProjectileSpells are not all of the same color.

Basically doing a spoiler with current "variables" is impossible. You'd need to 
create a new one for 1) color 2) "attack" and manually input the names of the 
abilities. Poe actually does not have much "attacks", mostly support gems, etc; 
probably the same way you made the RareGem variable.

Just check the active skills and remove all the auras/buffs; not hard to make a 
list.
http://pathofexile.gamepedia.com/Gem#Active_Skills

The major issue this version is the ForumExportTemplate.txt issue; it needs to 
be read via the xml just like added text file.

An idea I had for the future bringing up all the categories is the ability to 
create custom categories. 
How I would do it is:
1) Have Procurement scan the folder "custom_categories"

2) The name of the text file would be the category "variable" we use in our 
layouts.
Example: myCat.txt would be {myCat} in our layout

3) Inside the text file we can combine current categories, one per line and if 
it has no "-" inside of it that would mean that gems of that catagory would be 
excluded from myCat
-----------
Minion
Spell
-Support
-Corrupted
-------------
So {myCat} would be all gems that have the Minion tag, the Spell tag, and DO 
NOT have the Support or Corrupted tag because they have a - infront of it.

"Raise Zombie" would get linked but "Minion Damage" wont because of the 
-Support tag.

If the way the layout of Procurement is setup (Sorry did not read source yet), 
maybe the first line of the custom tag would be to define the kind of item it 
is, so in our case the first line would be:
Gem:
or if it was armour it would be:
Armour: 

--------------

Just a cool system to create something, but we do need more categories. 
1) The "Attack" category (Should exclude minions)
2) The "Color" category 

Basically everything would function as the "rare gems" variable as I'm sure 
it's just all a manual input. 

The custom category could be for any type of item, but it's not a priority just 
something cool; and not hard (Know how to program a bit); read folder, list all 
files, name of category is filename with the .txt extension substr and 
combination of categories would be the same function you use now.

In short, here's a list of suggestions in their priority: (Top = highest 
priority, lowest = can wait)
1) Rewrite "ForumExportTemplate.txt" so it functions just like custom .txt 
files we add so if we want to we can comment it out and not have it load 
anymore. Big problem solver for people with multiple shops because of size
2) Adding an option to remove duplicate items from the forum BBCode, so if a 
gem is in the quality section, it won't show up in "support"; a 5% quality 
faster casting won't go into the support gem's spoiler, popular gems spoiler, 
or leveled gems spoiler because it's already in the quality gems spoiler.
---You can take this a step further and have users have a priority list that 
they can choose their own priorities whether it's in the client or a text file.
---Priority list would look like:
Quality
Rare
Popular
Leveled
etc...(not a part of the list)

----for armour if an item is a unique it won't show up in IIQ/IIR with a 
possible priority list

3)A filter for "attack" gems as I mentioned
4)A filter for gems by their color
-------------all major suggestions done, now for minor/cool future changes
5) adding a folder to create your own category via the system I thought up 
above or something you think of that functions better

Thank you for procurement! 

Original comment by marat...@gmail.com on 14 Sep 2014 at 12:31

[GoogleCodeExporter]

Popular gems are in the .XML itself, 
May I suggest removing them from settings .xml and expand on the way popular 
gems work for the other systems I suggested and put them in a separate folder 
with separate xml's like popularGems.xml and so-on.

Original comment by marat...@gmail.com on 14 Sep 2014 at 12:39

[GoogleCodeExporter]

That's quite a detailed reply you've given there!

"ColdSpell does not bring up all cold attacks" - that is correct, it brings 
back all cold spells. If you want all cold attacks, use {ColdAttackGems}.

The gem category system as it currently stands is built directly off the data 
that GGG sends back, and how they categorise gems. I think your colour category 
is a good idea though, I'll see what I can do about adding that. 

With the multiple template idea, take a look at the wiki page on multiple forum 
templates, as it already allows you to create multiple templates for eg: 
different shops.

If you have a bit of programming experience, you can also always grab the 
source from github, and then send me a pull request if you have nice new 
features that you've added.

Original comment by stickymaddness on 14 Sep 2014 at 10:00

[GoogleCodeExporter]

You've already answered my question about the pull request, and yes I know how 
multiple shops work; I'm just annoyed that onload it picks 
"ForumExportTemplate.txt" and gives me a 5k error when I have other texts that 
are used for my shop. Either make Forum Export Template work like adding extra 
txts; inside the xml -- or make procurement remember the last .txt that was 
selected; the popup is a bit annoying.

I have looked at the source. Very nice, just a bit of organization with 
"popular gems" into a new XML and {ColdAttackGems} would not bring up say 
"Freezing Pulse" because it's Cold, Projectile, Spell; but would bring up 
"Cold, Attack, Melee" yet both are "blue attacks"; by attack I mean a spell 
that is not a support or aura, or minion summon, or buff; just click and you 
slash your sword or cast your wand or shoot your bow and damage is done.

Forget all this gem stuff for now, please fix the way "ForumExportTemplate" is 
handled, make it by default in the XML and if it is removed nothing happens. 
Thanks for helping on the project. I'm going to get visual studio and help out; 
I didn't program in a while aside from macros (made an awesome trade chat macro 
the other day) attached it.

The color system I can possibly work out via manual lists on how popular gems 
work when I handle school and have free time; for now forumexporttemplate and a 
refresh all button and I'm happy. I hate finding a cool item, having to open 
and close procurement just so it refreshes (I have 30+ tabs it's a bitch) but 
the latest tab saving feature made life so much easier! Thanks!

Original comment by marat...@gmail.com on 14 Sep 2014 at 7:37

Attachments:

• Trade.ahk