sheepla / pingu

🐧ping command but with pingu

MIT License

2.07k stars 64 forks source link

Mismatch Go version between go.mod and golangci-lint.yaml #16

Open sheepla opened 2 years ago

sheepla commented 2 years ago

I'm developing on Go v1.18 but golangci-lint is settings are set to a different version. So I want to fix.

go.mod: v1.18
golangci-lint.yaml: v1.17

10 Thank you for notice me, johnmanjiro13!

sheepla commented 2 years ago

golangci-lint#2649

some rules in go-critic (hugeParam, rangeValCopy, typeDefFirst, paramTypeCombine) don't work with generics and must be disabled by hand if you are not using generics (and your dependencies) you can use the following configuration:

run:
  go: '1.17'

This code in this repository hasn't used generics yet, so it doesn't seem to matter if it stays at v1.17.